Skip to content

fix(clerk-react): Fill out missing methods and properties from Isomor…#2228

Merged
panteliselef merged 1 commit into
elef/fix-missing-isomorphic-clerkfrom
tom/fix-missing-isomorphic-clerk
Nov 29, 2023
Merged

fix(clerk-react): Fill out missing methods and properties from Isomor…#2228
panteliselef merged 1 commit into
elef/fix-missing-isomorphic-clerkfrom
tom/fix-missing-isomorphic-clerk

Conversation

@tmilewski

Copy link
Copy Markdown
Member

Description

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski self-assigned this Nov 28, 2023
@changeset-bot

changeset-bot Bot commented Nov 28, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fd419b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@panteliselef
panteliselef marked this pull request as ready for review November 29, 2023 09:20
@panteliselef
panteliselef merged commit 4d73428 into elef/fix-missing-isomorphic-clerk Nov 29, 2023
@panteliselef
panteliselef deleted the tom/fix-missing-isomorphic-clerk branch November 29, 2023 09:20
github-merge-queue Bot pushed a commit that referenced this pull request Nov 29, 2023
…#2226)

* fix(clerk-react): Missing methods and properties from IsomorphicClerk

* fix(clerk-react): Fill out missing methods and properties from IsomorphicClerk (#2228)

* fix(clerk-react): Align implementation of isSatellite

* fix(clerk-react): Add changeset

* chore(clerk-react): Remove todos

* fix(clerk-react): Replace optional Clerk properties with undefined

* fix(clerk-js): Add missing sdkMetadata getter

---------

Co-authored-by: Tom Milewski <me@tm.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants